Skip to content

Need to reorganize / edit "Managing Dependencies" section #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Gaurav0 opened this issue Oct 11, 2018 · 3 comments
Closed

Need to reorganize / edit "Managing Dependencies" section #21

Gaurav0 opened this issue Oct 11, 2018 · 3 comments

Comments

@Gaurav0
Copy link
Contributor

Gaurav0 commented Oct 11, 2018 •
edited
Loading

I don't think this belongs in "writing addons" because this is mostly about importing and customizing dependencies which can either be done in the app via ember-cli-build.js or in the addon via index.js. How exactly it should be organized probably deserves further discussion on discord. There is a discussion about this on Discord here: https://discordapp.com/channels/480462759797063690/480777444203429888/499943437626507274

See also my review here: #19 (review)
@BradenLawrence
Copy link
Contributor

Thanks for reviewing and adding this issue! I can pick up a few of the items you called out:

  • "Mention it will use yarn when there is both a yarn.lock and a package-lock.json"
  • "It should be not recommended to use bower. It is not officially deprecated, but it should be."
  • "but does not watch node_modules."
    I'll add any followup questions inline with your review.

@jenweber
Copy link
Contributor

Proposed breakdown:

Basic Use - Importing Assets
Advanced Use - Managing Dependencies
Writing Addons - Including Assets In Addons

Copied from Gaurav's comments on #24

@jenweber jenweber mentioned this issue Oct 20, 2018
Merged
BradenLawrence added a commit to BradenLawrence/cli-guides-source that referenced this issue Oct 20, 2018
@BradenLawrence
Remove references to Bower
0d979e0 
 - Partially addressing issue ember-learn#21
 - Followup to PR ember-learn#19
 - Replaced Bower with Yarn where it makes sense
 - Explained interaction between yarn.lock and package-lock.json
 - Explained how EmberCLI does not watch for npm install packages
 - Did NOT address any of the Bower references within code examples
@BradenLawrence BradenLawrence mentioned this issue Oct 20, 2018
Merged
Gaurav0 pushed a commit that referenced this issue Oct 26, 2018
@BradenLawrence @Gaurav0
Remove references to Bower (#26)
0b684e2 
* Remove references to Bower
 - Partially addressing issue #21
 - Followup to PR #19
 - Replaced Bower with Yarn where it makes sense
 - Explained interaction between yarn.lock and package-lock.json
 - Explained how EmberCLI does not watch for npm install packages
 - Did NOT address any of the Bower references within code examples

* Correct capitalization and improve clarity
 - Change all instances of NPM to npm
 - Change all instances of yarn to Yarn
 - Clarify users would be installing and using Yarn,
   not just including a yarn.lock file
 - Add node_module as a location assets can be imported from
@jenweber
Copy link
Contributor

Closed by #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Gaurav0 @jenweber @BradenLawrence