Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Component#isVisible #451

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Deprecate Component#isVisible #451

merged 1 commit into from
Oct 17, 2019

Conversation

GavinJoyce
Copy link
Contributor

@GavinJoyce GavinJoyce mentioned this pull request Oct 14, 2019
Merged
4 tasks
@GavinJoyce GavinJoyce force-pushed the gj/component-isVisible branch 2 times, most recently from 372b1ac to 123fa99 Compare October 17, 2019 08:47
@GavinJoyce GavinJoyce changed the title [WIP] deprecate Component#isVisible Deprecate Component#isVisible Oct 17, 2019
@GavinJoyce GavinJoyce force-pushed the gj/component-isVisible branch from 123fa99 to 71283e6 Compare October 17, 2019 08:57
@rwjblue rwjblue merged commit 38a40af into ember-learn:master Oct 17, 2019
@rwjblue
Copy link
Contributor

rwjblue commented Oct 17, 2019

Thank you!

@GavinJoyce GavinJoyce deleted the gj/component-isVisible branch October 17, 2019 19:56
@GavinJoyce GavinJoyce mentioned this pull request Oct 17, 2019
Merged
@GavinJoyce
Copy link
Contributor Author

I missed a ): #454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GavinJoyce @rwjblue