Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC#236] Add guide for String prototype extensions deprecation #696

Merged
merged 6 commits into from
Oct 29, 2020
Merged

[RFC#236] Add guide for String prototype extensions deprecation #696

merged 6 commits into from
Oct 29, 2020

Conversation

locks
Copy link
Contributor

@locks locks commented Oct 27, 2020 •
edited
Loading

Part of RFC#236 - Ember.String deprecation.
PR twin of emberjs/ember.js#19234.

Tasks

  • deprecate String prototype extensions
    • make sure deprecation URL is published and matches

@locks locks changed the title add deprecation guide for String prototype extensions Add deprecation guide for String prototype extensions Oct 27, 2020
@locks locks force-pushed the deprecate-ember-string-prototype-extension branch 2 times, most recently from 6b3ad38 to a636607 Compare October 27, 2020 11:09
@locks locks changed the title Add deprecation guide for String prototype extensions Add guide for String prototype extensions deprecation Oct 27, 2020
@locks locks mentioned this pull request Oct 27, 2020
Closed
17 tasks
@locks locks force-pushed the deprecate-ember-string-prototype-extension branch 2 times, most recently from 3ae358a to 9640507 Compare October 27, 2020 11:32
@locks locks mentioned this pull request Oct 27, 2020
Merged
@locks locks changed the title Add guide for String prototype extensions deprecation [RFC#236] Add guide for String prototype extensions deprecation Oct 27, 2020
@locks locks force-pushed the deprecate-ember-string-prototype-extension branch from 9640507 to 1b0e8df Compare October 27, 2020 11:43
ijlee2
ijlee2 approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you explained the RFC well and concisely. Thanks for working on the write-up! I left a few optional suggestions.

locks and others added 3 commits October 29, 2020 13:22
@locks @ijlee2
Update content/ember/v3/ember-string-prototype-extensions.md
11f5a4b 
Co-authored-by: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
@locks @ijlee2
Update content/ember/v3/ember-string-prototype-extensions.md
78b44e6 
Co-authored-by: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
@locks @ijlee2
Update content/ember/v3/ember-string-prototype-extensions.md
8ff2da9 
Co-authored-by: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
@locks
Copy link
Contributor Author

locks commented Oct 29, 2020

Thanks for the feedback! I'm merging it in and we can continue iterating once the other deprecations are released.

@locks locks merged commit e4a6236 into master Oct 29, 2020
@locks locks deleted the deprecate-ember-string-prototype-extension branch October 29, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijlee2 ijlee2 ijlee2 approved these changes

@mansona mansona mansona approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@locks @mansona @ijlee2