Skip to content

Merge main #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Jul 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
1da6e33
update percy
mansona Jun 21, 2024
e0bf0f6
Merge pull request #911 from ember-learn/percy
mansona Jun 21, 2024
ef7a9e7
add new percy snapshots
mansona Jun 21, 2024
7424827
Merge pull request #912 from ember-learn/add-new-percy
mansona Jun 21, 2024
e0e75ab
switch to embroider
mansona Dec 8, 2023
9c25b0c
remove unused test files
mansona Dec 8, 2023
b58c8f6
update styleguide
mansona Dec 8, 2023
0c69fbf
fix embroider
mansona Jan 27, 2024
fc8a57b
fix prember for embroider
mansona Jan 27, 2024
c370dfa
remove unused ember-exam
mansona Jun 7, 2024
8e42dd3
fix header alignment
mansona Jun 7, 2024
b1f4e53
Merge pull request #903 from ember-learn/embroider
mansona Jun 25, 2024
f2f61be
fix require-expect lint
mansona Jul 5, 2024
a5b4a45
Merge pull request #914 from ember-learn/fix-require-expect
mansona Jul 5, 2024
4bf8cfc
install showdown and prism
mansona Jan 12, 2024
4fddccb
use markdown-to-html for all descriptions
mansona Jan 12, 2024
c87af01
WIP ⚠️ use markdown branch
mansona Jan 12, 2024
183b27d
make import-example use the same code block as markdown
mansona Jun 25, 2024
43ab518
remove custom highlighting styles
mansona Jan 12, 2024
24d35cd
update prember
mansona Jun 27, 2024
cf5daf8
switch to ember-cli-shiki
mansona Jul 5, 2024
cecf280
refactor: allow @warp-drive in data docs
jaredgalanis Jul 6, 2024
0dc28b2
add a warp-drive test
jaredgalanis Jul 6, 2024
f38cbcb
Merge pull request #916 from ember-learn/refactor-allow-@warp-drive-i…
jaredgalanis Jul 6, 2024
46a7bdf
Merge pull request #902 from ember-learn/markdown
MinThaMie Jul 8, 2024
d3d91f4
go back to using main branch for data
mansona Jul 8, 2024
72cb615
Merge pull request #918 from ember-learn/use-main
mansona Jul 9, 2024
f9c1ecd
Merge remote-tracking branch 'origin/main' into merge-main
mansona Jul 9, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/components/class-field-description.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,14 @@
<div class='parameter'>
<dt>{{param.name}}</dt>
<dd class='parameter-type'>{{param.type}}</dd>
<dd>{{param.description}}</dd>
<dd><MarkdownToHtml @markdown={{param.description}} /></dd>
{{#if param.props}}
<dl class='parameters'>
{{#each param.props as |prop|}}
<div class='prop'>
<dt>{{prop.name}}</dt>
<dd class='parameter-type'>{{prop.type}}</dd>
<dd>{{prop.description}}</dd>
<dd><MarkdownToHtml @markdown={{prop.description}} /></dd>
</div>
{{/each}}
</dl>
Expand All @@ -72,9 +72,9 @@
<div class='return'>
<dt>returns</dt>
<dd class='return-type'>{{@field.return.type}}</dd>
<dd>{{@field.return.description}}</dd>
<dd><MarkdownToHtml @markdown={{@field.return.description}} /></dd>
</div>
{{/if}}
</dl>
{{html-safe @field.description}}
<MarkdownToHtml @markdown={{@field.description}} />
</section>
22 changes: 1 addition & 21 deletions app/components/import-example.hbs
Original file line number Diff line number Diff line change
@@ -1,21 +1 @@
<div class='highlight javascript'>
<div class='ribbon'></div>
{{#if (is-clipboard-supported)}}
<div class='import-copy'>
{{#if this.showClipboardSuccessIcon}}
{{svg-jar 'success' width='24px' height='24px'}}
{{else}}
<CopyButton @clipboardText={{concat 'import ' @item " from '" @package "';"}} @title='Copy to clipboard' @success={{this.showSuccess}}>
{{svg-jar 'copy' width='24px' height='24px'}}
</CopyButton>
{{/if}}
</div>
{{/if}}
<table class='CodeRay'>
<tbody>
<tr>
<td class='code'><pre><span class='wrapper'><span class='keyword'>import</span> {{@item}} <span class='keyword'>from</span> <span class='string'>'{{@package}}'</span>;</span></pre></td>
</tr>
</tbody>
</table>
</div>
<MarkdownToHtml @markdown={{this.markdown}} />
14 changes: 5 additions & 9 deletions app/components/import-example.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,10 @@
import { action } from '@ember/object';
import Component from '@glimmer/component';
import { later } from '@ember/runloop';
import { tracked } from '@glimmer/tracking';

export default class ImportExample extends Component {
@tracked showClipboardSuccessIcon = false;

@action
showSuccess() {
this.showClipboardSuccessIcon = true;
later(this, () => (this.showClipboardSuccessIcon = false), 950);
get markdown() {
let md = `\`\`\`js
import ${this.args.item} from '${this.args.package}';
\`\`\``;
return md;
}
}
2 changes: 1 addition & 1 deletion app/controllers/project-version/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Controller from '@ember/controller';
import { htmlSafe } from '@ember/string';
import { htmlSafe } from '@ember/template';

export default Controller.extend({
oldPackageImportSyntax: htmlSafe(
Expand Down
2 changes: 1 addition & 1 deletion app/helpers/html-safe.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { helper } from '@ember/component/helper';
import { htmlSafe as emberHtmlSafe } from '@ember/string';
import { htmlSafe as emberHtmlSafe } from '@ember/template';

export function htmlSafe([content]) {
return emberHtmlSafe(content);
Expand Down
2 changes: 1 addition & 1 deletion app/routes/project-version/modules/module.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export default class ModuleRoute extends ClassRoute.extend(ScrollTracker) {

// These modules should not have `ember-` tacked onto the front of them
// when forming the ids and URLs.
let isNotEmber = klass.match(/@glimmer|rsvp|jquery/);
let isNotEmber = klass.match(/@warp-drive|@glimmer|rsvp|jquery/);

if (!~klass.indexOf(project) && !isNotEmber) {
klass = `${project}-${klass}`;
Expand Down
2 changes: 1 addition & 1 deletion app/templates/project-version/classes/class.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
{{#if (and (not (eq this.static 1)) this.hasImportExample)}}
<ImportExample @item={{@model.name}} @package={{this.module}} />
{{/if}}
<p class="description">{{html-safe @model.description}}</p>
<p class="description"><MarkdownToHtml @markdown={{@model.description}} /></p>

{{#if (or @model.methods @model.properties @model.events)}}
<div class="tabbed-layout">
Expand Down
2 changes: 1 addition & 1 deletion app/templates/project-version/modules/module.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
{{/if}}
</p>

<p class="description">{{html-safe this.model.description}}</p>
<p class="description"><MarkdownToHtml @markdown={{this.model.description}} /></p>

{{#if this.submodules}}
<section>
Expand Down
9 changes: 9 additions & 0 deletions config/fastboot.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
module.exports = function () {
return {
buildSandboxGlobals(defaultGlobals) {
return Object.assign({}, defaultGlobals, {
atob: atob,
});
},
};
};
11 changes: 10 additions & 1 deletion ember-cli-build.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,14 @@ module.exports = function (defaults) {
destDir: '/assets/',
});

return mergeTrees([app.toTree(), mappingsTree]);
const { Webpack } = require('@embroider/webpack');
const appTree = require('@embroider/compat').compatBuild(app, Webpack, {
staticAddonTrees: true,
staticAddonTestSupportTrees: true,
staticHelpers: true,
staticModifiers: true,
staticComponents: true,
});

return mergeTrees([require('prember').prerender(app, appTree), mappingsTree]);
};
18 changes: 11 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,15 @@
"devDependencies": {
"@ember/optional-features": "^2.0.0",
"@ember/test-helpers": "^2.6.0",
"@embroider/compat": "^3.4.3",
"@embroider/core": "^3.4.3",
"@embroider/webpack": "^3.2.1",
"@glimmer/component": "^1.1.2",
"@glimmer/tracking": "^1.1.2",
"@glint/core": "^0.9.7",
"@glint/environment-ember-loose": "^0.9.7",
"@percy/cli": "^1.14.0",
"@percy/ember": "^3.0.1",
"@percy/cli": "^1.28.7",
"@percy/ember": "^4.2.0",
"@tsconfig/ember": "^1.0.1",
"@types/ember": "^4.0.2",
"@types/ember-qunit": "^5.0.2",
Expand All @@ -58,7 +61,7 @@
"broccoli-merge-trees": "^2.0.0",
"ember-a11y-testing": "^0.5.4",
"ember-anchor": "^1.0.3",
"ember-auto-import": "^2.7.0",
"ember-auto-import": "^2.7.2",
"ember-cli": "~3.28.6",
"ember-cli-app-version": "^5.0.0",
"ember-cli-autoprefixer": "^1.0.0",
Expand All @@ -75,25 +78,26 @@
"ember-cli-htmlbars": "^6.1.1",
"ember-cli-inject-live-reload": "^2.1.0",
"ember-cli-meta-tags": "^7.0.0",
"ember-cli-showdown": "^9.0.1",
"ember-cli-terser": "^4.0.2",
"ember-composable-helpers": "^3.1.1",
"ember-concurrency": "^2.3.7",
"ember-data": "~3.28.6",
"ember-data-fastboot": "https://github.com/cardstack/ember-data-fastboot#6e6fb8bbf0b405ae174160cc1e4833c5582f68cd",
"ember-decorators": "^6.1.1",
"ember-exam": "^1.0.0",
"ember-export-application-global": "^2.0.1",
"ember-fetch": "^8.1.1",
"ember-inflector": "^3.0.0",
"ember-load-initializers": "^2.1.2",
"ember-maybe-import-regenerator": "^0.1.6",
"ember-metrics": "^1.5.2",
"ember-page-title": "^6.2.2",
"ember-power-select": "^4.1.6",
"ember-power-select": "^6.0.1",
"ember-qunit": "^5.1.5",
"ember-resolver": "^8.0.3",
"ember-rfc176-data": "^0.3.17",
"ember-route-action-helper": "^2.0.5",
"ember-showdown-shiki": "^1.2.1",
"ember-sinon": "^4.1.1",
"ember-source": "~3.28.8",
"ember-styleguide": "^8.3.0",
Expand Down Expand Up @@ -125,7 +129,7 @@
"node-sass": "^9.0.0",
"normalize.css": "^8.0.1",
"npm-run-all": "^4.1.5",
"prember": "^2.0.0",
"prember": "^2.1.0",
"prettier": "^2.5.1",
"qunit": "^2.17.2",
"qunit-dom": "^1.6.0",
Expand All @@ -135,7 +139,7 @@
"spawndamnit": "2.0.0",
"testem": "^3.10.0",
"typescript": "^4.9.3",
"webpack": "^5.89.0"
"webpack": "^5.90.0"
},
"engines": {
"node": "16.* || 18.* || 20.*",
Expand Down
Loading