Skip to content

update lint implementation to support gjs #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 15 additions & 27 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,15 @@

module.exports = {
root: true,
parser: 'babel-eslint',
parser: '@babel/eslint-parser',
parserOptions: {
ecmaVersion: 2018,
ecmaVersion: 'latest',
sourceType: 'module',
ecmaFeatures: {
legacyDecorators: true,
requireConfigFile: false,
babelOptions: {
plugins: [
['@babel/plugin-proposal-decorators', { decoratorsBeforeExport: true }],
],
},
},
plugins: ['ember'],
Expand All @@ -19,52 +22,37 @@ module.exports = {
env: {
browser: true,
},
rules: {
'no-console': 'off',
'ember/no-new-mixins': 'off',
'ember/no-mixins': 'off',
'ember/require-tagless-components': 'off',
'ember/no-classic-classes': 'off',
'ember/no-get': 'off',
'ember/no-classic-components': 'off',
'ember/no-private-routing-service': 'off',
},
rules: {},
overrides: [
{
files: ['**/*.gjs'],
parser: 'ember-eslint-parser',
},
// node files
{
files: [
'./.eslintrc.js',
'./.prettierrc.js',
'./.stylelintrc.js',
'./.template-lintrc.js',
'./ember-cli-build.js',
'./testem.js',
'./blueprints/*/index.js',
'./config/**/*.js',
'./lib/*/index.js',
'./server/**/*.js',
'./run-tests.js',
'./bin/*',
'./prember-urls.js',
],
excludedFiles: ['config/deprecation-workflow.js'],
parserOptions: {
sourceType: 'script',
ecmaVersion: 2017,
},
env: {
browser: false,
node: true,
},
plugins: ['node'],
extends: ['plugin:node/recommended'],
rules: {
// this can be removed once the following is fixed
// https://github.com/mysticatea/eslint-plugin-node/issues/77
'node/no-unpublished-require': 'off',
},
extends: ['plugin:n/recommended'],
},
{
// Test files:
// test files
files: ['tests/**/*-test.{js,ts}'],
extends: ['plugin:qunit/recommended'],
},
Expand Down
4 changes: 4 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,12 @@
/coverage/
!.*
.eslintcache
.lint-todo/

# ember-try
/.node_modules.ember-try/
/bower.json.ember-try
/npm-shrinkwrap.json.ember-try
/package.json.ember-try
/package-lock.json.ember-try
/yarn.lock.ember-try
10 changes: 9 additions & 1 deletion .prettierrc.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
'use strict';

module.exports = {
singleQuote: true,
plugins: ['prettier-plugin-ember-template-tag'],
overrides: [
{
files: '*.{js,ts,gjs,gts}',
options: {
singleQuote: true,
},
},
],
};
10 changes: 10 additions & 0 deletions .template-lintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,14 @@

module.exports = {
extends: 'recommended',
overrides: [
{
files: ['tests/**/*'],
rules: {
'no-potential-path-strings': false,
'no-curly-component-invocation': false,
'no-action': false,
},
},
],
};
1 change: 1 addition & 0 deletions app/adapters/application.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable prettier/prettier */
import { inject as service } from '@ember/service';
import JSONAPIAdapter from '@ember-data/adapter/json-api';
import fetch from 'fetch';
Expand Down
2 changes: 1 addition & 1 deletion app/components/api-index-filter.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* eslint-disable ember/no-computed-properties-in-native-classes */
/* eslint-disable ember/no-classic-components, ember/no-computed-properties-in-native-classes, ember/require-tagless-components */
import { classNames } from '@ember-decorators/component';
import { computed } from '@ember/object';
import Component from '@ember/component';
Expand Down
1 change: 1 addition & 0 deletions app/components/class-field-description.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable prettier/prettier */
import { inject as service } from '@ember/service';
import Component from '@glimmer/component';
import { action } from '@ember/object';
Expand Down
2 changes: 1 addition & 1 deletion app/components/ember-anchor.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* eslint-disable ember/classic-decorator-no-classic-methods */
/* eslint-disable ember/classic-decorator-no-classic-methods, prettier/prettier */
import AnchorComponent from 'ember-anchor/components/ember-anchor';
import config from 'ember-api-docs/config/environment';
import getOffset from 'ember-api-docs/utils/get-offset';
Expand Down
1 change: 1 addition & 0 deletions app/components/search-input.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable ember/no-get */
import { inject as service } from '@ember/service';
import Component from '@glimmer/component';
import { get } from '@ember/object';
Expand Down
1 change: 1 addition & 0 deletions app/components/search-input/dropdown-result.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable ember/no-classic-classes, ember/no-classic-components, ember/no-get, ember/require-tagless-components, prettier/prettier */
import { gt } from '@ember/object/computed';
import { computed } from '@ember/object';
import Component from '@ember/component';
Expand Down
1 change: 1 addition & 0 deletions app/components/search-input/dropdown.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable ember/no-classic-components, ember/no-get, ember/require-tagless-components, prettier/prettier */
import {
classNames,
attributeBindings,
Expand Down
1 change: 1 addition & 0 deletions app/controllers/events.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable ember/no-mixins, prettier/prettier */
import { inject as service } from '@ember/service';
import Controller from '@ember/controller';
import AnchorControllerSupport from 'ember-anchor/mixins/controller-support';
Expand Down
1 change: 1 addition & 0 deletions app/controllers/methods.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable ember/no-mixins, prettier/prettier */
import { inject as service } from '@ember/service';
import Controller from '@ember/controller';
import AnchorControllerSupport from 'ember-anchor/mixins/controller-support';
Expand Down
2 changes: 1 addition & 1 deletion app/controllers/project-version.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* eslint-disable ember/no-computed-properties-in-native-classes */
/* eslint-disable ember/no-computed-properties-in-native-classes, prettier/prettier */
import { action, computed, set } from '@ember/object';
import { inject as service } from '@ember/service';
import { readOnly, alias } from '@ember/object/computed';
Expand Down
2 changes: 1 addition & 1 deletion app/controllers/project-version/classes/class.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* eslint-disable ember/no-computed-properties-in-native-classes, ember/classic-decorator-no-classic-methods */
/* eslint-disable ember/classic-decorator-no-classic-methods, ember/no-computed-properties-in-native-classes, ember/no-get, prettier/prettier */
import { action, computed, set, get } from '@ember/object';
import { inject as service } from '@ember/service';
import Controller from '@ember/controller';
Expand Down
1 change: 1 addition & 0 deletions app/controllers/project-version/index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable ember/no-classic-classes, prettier/prettier */
import Controller from '@ember/controller';
import { htmlSafe } from '@ember/template';

Expand Down
2 changes: 1 addition & 1 deletion app/controllers/project-version/modules/module.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* eslint-disable ember/no-computed-properties-in-native-classes, ember/classic-decorator-no-classic-methods */
/* eslint-disable ember/classic-decorator-no-classic-methods, ember/no-computed-properties-in-native-classes, ember/no-get, prettier/prettier */
import { computed } from '@ember/object';
import { inject as service } from '@ember/service';
import { alias } from '@ember/object/computed';
Expand Down
2 changes: 1 addition & 1 deletion app/controllers/properties.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* eslint-disable ember/classic-decorator-no-classic-methods */
/* eslint-disable ember/classic-decorator-no-classic-methods, ember/no-mixins, prettier/prettier */
import { action } from '@ember/object';
import { inject as service } from '@ember/service';
import Controller from '@ember/controller';
Expand Down
1 change: 1 addition & 0 deletions app/helpers/github-link.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable prettier/prettier */
import { helper } from '@ember/component/helper';
import githubMap, { mainDir } from '../utils/github-map';

Expand Down
1 change: 1 addition & 0 deletions app/instance-initializers/ember-meta-store.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable prettier/prettier */
import { isPresent } from '@ember/utils';

export function initialize(appInstance) {
Expand Down
1 change: 1 addition & 0 deletions app/mixins/scroll-tracker.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable ember/no-new-mixins, prettier/prettier */
import Mixin from '@ember/object/mixin';
import { inject as service } from '@ember/service';
import config from 'ember-api-docs/config/environment';
Expand Down
2 changes: 1 addition & 1 deletion app/models/class.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* eslint-disable ember/no-computed-properties-in-native-classes, ember/classic-decorator-no-classic-methods */
/* eslint-disable ember/classic-decorator-no-classic-methods, ember/no-computed-properties-in-native-classes, ember/no-get, prettier/prettier */
import { computed } from '@ember/object';
import Model, { belongsTo, attr } from '@ember-data/model';

Expand Down
1 change: 1 addition & 0 deletions app/models/project-version.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable ember/no-classic-classes */
import Model, { attr, hasMany, belongsTo } from '@ember-data/model';
import { computed } from '@ember/object';
import getCompactVersion from '../utils/get-compact-version';
Expand Down
1 change: 1 addition & 0 deletions app/router.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable ember/no-runloop, prettier/prettier */
import EmberRouter from '@ember/routing/router';
import { scheduleOnce } from '@ember/runloop';
import config from 'ember-api-docs/config/environment';
Expand Down
1 change: 1 addition & 0 deletions app/routes/application.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable prettier/prettier */
import { inject as service } from '@ember/service';
import Route from '@ember/routing/route';
import { set } from '@ember/object';
Expand Down
1 change: 1 addition & 0 deletions app/routes/class.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable prettier/prettier */
import { inject as service } from '@ember/service';
import Route from '@ember/routing/route';

Expand Down
1 change: 1 addition & 0 deletions app/routes/data-class.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable prettier/prettier */
import { inject as service } from '@ember/service';
import Route from '@ember/routing/route';

Expand Down
1 change: 1 addition & 0 deletions app/routes/data-module.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable prettier/prettier */
import { inject as service } from '@ember/service';
import Route from '@ember/routing/route';

Expand Down
1 change: 1 addition & 0 deletions app/routes/module.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable prettier/prettier */
import { inject as service } from '@ember/service';
import Route from '@ember/routing/route';

Expand Down
1 change: 1 addition & 0 deletions app/routes/project-version.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable ember/no-implicit-injections, prettier/prettier */
import { action } from '@ember/object';
import { inject as service } from '@ember/service';
import Route from '@ember/routing/route';
Expand Down
1 change: 1 addition & 0 deletions app/routes/project-version/classes/class.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable ember/no-implicit-injections, ember/no-mixins, prettier/prettier */
import { inject as service } from '@ember/service';
import { resolve, all } from 'rsvp';
import Route from '@ember/routing/route';
Expand Down
1 change: 1 addition & 0 deletions app/routes/project-version/functions/function.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable ember/no-implicit-injections, prettier/prettier */
import { inject as service } from '@ember/service';
import Route from '@ember/routing/route';
import getFullVersion from 'ember-api-docs/utils/get-full-version';
Expand Down
1 change: 1 addition & 0 deletions app/routes/project-version/modules/module.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable ember/no-mixins, prettier/prettier */
import ClassRoute from '../classes/class';
import ScrollTracker from 'ember-api-docs/mixins/scroll-tracker';
import getFullVersion from 'ember-api-docs/utils/get-full-version';
Expand Down
1 change: 1 addition & 0 deletions app/routes/project-version/namespaces/namespace.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable ember/no-mixins, prettier/prettier */
import ClassRoute from '../classes/class';
import ScrollTracker from 'ember-api-docs/mixins/scroll-tracker';
import getFullVersion from 'ember-api-docs/utils/get-full-version';
Expand Down
1 change: 1 addition & 0 deletions app/routes/project.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable ember/no-implicit-injections, ember/no-mixins, prettier/prettier */
import Route from '@ember/routing/route';
import ScrollTracker from 'ember-api-docs/mixins/scroll-tracker';
import { inject as service } from '@ember/service';
Expand Down
1 change: 1 addition & 0 deletions app/services/algolia.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable prettier/prettier */
import Service from '@ember/service';
import algoliasearch from 'algoliasearch';
import config from 'ember-api-docs/config/environment';
Expand Down
1 change: 1 addition & 0 deletions app/services/legacy-module-mappings.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable prettier/prettier */
import Service from '@ember/service';
import { tracked } from '@glimmer/tracking';

Expand Down
1 change: 1 addition & 0 deletions app/services/meta-store.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable prettier/prettier */
import Service from '@ember/service';
import { isPresent } from '@ember/utils';
import { set } from '@ember/object';
Expand Down
1 change: 1 addition & 0 deletions app/services/scroll-position-reset.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable prettier/prettier */
import Service from '@ember/service';
import config from '../config/environment';
import getOffset from '../utils/get-offset';
Expand Down
1 change: 1 addition & 0 deletions app/services/search.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable ember/no-classic-classes */
import Service, { inject as service } from '@ember/service';
import { task } from 'ember-concurrency';
import { set } from '@ember/object';
Expand Down
2 changes: 1 addition & 1 deletion app/templates/project-version.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{! template-lint-disable no-inline-styles }}
{{! template-lint-disable no-inline-styles no-route-action }}
<aside class="sidebar">
<ol class="toc-level-0">
<li class="toc-level-0" data-test-home>
Expand Down
1 change: 1 addition & 0 deletions app/templates/project-version/modules/module.hbs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{! template-lint-disable no-invalid-link-text }}
<article class="chapter">
{{#if (eq this.model.name 'ember-data-overview')}}
<h1 class="module-name">EmberData Overview</h1>
Expand Down
1 change: 1 addition & 0 deletions app/utils/get-full-version.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable prettier/prettier */
import getCompactVersion from 'ember-api-docs/utils/get-compact-version';
import getLastVersion from 'ember-api-docs/utils/get-last-version';

Expand Down
1 change: 1 addition & 0 deletions app/utils/request-idle-callback.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable ember/no-runloop */
import RSVP from 'rsvp';
import { run } from '@ember/runloop';

Expand Down
Loading
Loading