Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: For EmberTimes No. 103 - Unused Components and Explicit Service Injection #161

Merged
merged 6 commits into from
Jun 21, 2019
Merged

WIP: For EmberTimes No. 103 - Unused Components and Explicit Service Injection #161

merged 6 commits into from
Jun 21, 2019

Conversation

jayjayjpg
Copy link
Contributor

What it does

Related Issue(s)

Sources

@jayjayjpg jayjayjpg requested a review from a team June 21, 2019 09:47
ijlee2
ijlee2 approved these changes Jun 21, 2019
View reviewed changes
Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jessica, these look great, thank you! I made a couple of suggestions for punctuation, to help readers more easily understand your message.

jayjayjpg and others added 3 commits June 21, 2019 21:44
@jayjayjpg @ijlee2
Update source/2019-06-21-the-ember-times-issue-103.md
cc977a5 
Co-Authored-By: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
@jayjayjpg @ijlee2
Update source/2019-06-21-the-ember-times-issue-103.md
7c5924e 
Co-Authored-By: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
@jayjayjpg
Merge branch 'blog/embertimes-103-fix' into embertimes-jj103
2eb6865
@jayjayjpg jayjayjpg merged commit 8a1f4ec into ember-learn:blog/embertimes-103-fix Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijlee2 ijlee2 ijlee2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayjayjpg @ijlee2