Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Ember Times No. 104 - Readers' Questions: What is Embroider? #167

Merged
merged 2 commits into from
Jun 28, 2019

Conversation

jayjayjpg
Copy link
Contributor

What it does

Related Issue(s)

Sources

@jayjayjpg jayjayjpg changed the base branch from master to blog/embertimes-104 June 27, 2019 08:59
@jayjayjpg jayjayjpg changed the title WIP: For Ember Times No. 104 - Readers' Questions: What is Embroider? For Ember Times No. 104 - Readers' Questions: What is Embroider? Jun 27, 2019
@@ -98,17 +99,19 @@ Halò Emberistas! 🐹
<p>This week we'd like to thank our siblings for their contributions to Ember and related repositories! 💖</p>

---

## [Got a Question? Ask Readers' Questions! 🤓](https://docs.google.com/forms/d/e/1FAIpQLScqu7Lw_9cIkRtAiXKitgkAo4xX_pV1pdCfMJgIr6Py1V-9Og/viewform)
## [Readers' Questions: What is Embroider?](https://discuss.emberjs.com/t/readers-questions-what-is-embroider/16722)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can display this section at the very top, in case there are readers who don't know Embroider well. Placing it on top would help them understand what Embroider is, before we ask them to read further with other Embroider-related articles. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that sounds good! I'll edit that once I'm back at a computer tomorrow morning

Copy link
Member

@amyrlam amyrlam Jun 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds great...I'm going to try moving this myself, so can get a head start on the issue

woohoo, let me commit!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank so much @amyrlam

@amyrlam amyrlam merged commit f64b38e into ember-learn:blog/embertimes-104 Jun 28, 2019
@jayjayjpg jayjayjpg deleted the embertimes-jj branch June 28, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants