Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For Ember Times No. 105: Async Observers #171

Merged
merged 4 commits into from
Jul 2, 2019
Merged

For Ember Times No. 105: Async Observers #171

merged 4 commits into from
Jul 2, 2019

Conversation

jayjayjpg
Copy link
Contributor

Part of #164

What it does

Related Issue(s)

Sources

@jayjayjpg jayjayjpg requested a review from a team July 1, 2019 18:49
ijlee2
ijlee2 approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading your article and the RFC was illuminating, thanks!

jayjayjpg and others added 3 commits July 2, 2019 09:38
@jayjayjpg @ijlee2
Update source/2019-07-05-the-ember-times-issue-105.md
904bbb2 
Co-Authored-By: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
@jayjayjpg @ijlee2
Update source/2019-07-05-the-ember-times-issue-105.md
7c9494a 
Co-Authored-By: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
@jayjayjpg
blog(embertimes#105): copy edits
68590cd
@jayjayjpg jayjayjpg merged commit b05cf7d into ember-learn:blog/embertimes-105 Jul 2, 2019
@jayjayjpg jayjayjpg deleted the embertimes-jj branch July 2, 2019 08:19
@jayjayjpg
Copy link
Contributor Author

Yes sure and thanks a lot for the thorough review @ijlee2 ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijlee2 ijlee2 ijlee2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayjayjpg @ijlee2