Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inspector post #173

Merged
merged 9 commits into from
Jul 5, 2019
Merged

Add inspector post #173

merged 9 commits into from
Jul 5, 2019

Conversation

RobbieTheWagner
Copy link
Member

Just a brief blurb on inspector

Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great! I left a few more suggestions for reference links - feel free to apply any of those that you see fit. Also, do you mind adding a short intro sentence to the top introduction section in this file similar to the other two that are already there? Apart from that, this is already good to go and thank you for writing for the Ember Times this week ✨

source/2019-07-05-the-ember-times-issue-105.md Outdated Show resolved Hide resolved
source/2019-07-05-the-ember-times-issue-105.md Outdated Show resolved Hide resolved
source/2019-07-05-the-ember-times-issue-105.md Outdated Show resolved Hide resolved
source/2019-07-05-the-ember-times-issue-105.md Outdated Show resolved Hide resolved
source/2019-07-05-the-ember-times-issue-105.md Outdated Show resolved Hide resolved
RobbieTheWagner and others added 7 commits July 5, 2019 08:31
Co-Authored-By: Jessica Jordan <jessica.jordan.fe.dev@gmail.com>
Co-Authored-By: Jessica Jordan <jessica.jordan.fe.dev@gmail.com>
Co-Authored-By: Jessica Jordan <jessica.jordan.fe.dev@gmail.com>
Co-Authored-By: Jessica Jordan <jessica.jordan.fe.dev@gmail.com>
Co-Authored-By: Jessica Jordan <jessica.jordan.fe.dev@gmail.com>
@RobbieTheWagner
Copy link
Member Author

@jessica-jordan thanks for all the suggestions! Is everything good to go now?

Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great! Thank you for a ✨ writeup to the Ember Times this week!

@jayjayjpg jayjayjpg merged commit 6dff94b into blog/embertimes-105 Jul 5, 2019
@jayjayjpg jayjayjpg deleted the inspector-update branch July 5, 2019 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants