Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog(embertimes131): new test waiters #491

Merged
merged 5 commits into from
Jan 16, 2020
Merged

blog(embertimes131): new test waiters #491

merged 5 commits into from
Jan 16, 2020

Conversation

chrisrng
Copy link
Member

No description provided.

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Jan 15, 2020
@amyrlam amyrlam force-pushed the blog/embertimes-131 branch from cccb4dc to a1e9a87 Compare January 16, 2020 03:48
amyrlam
amyrlam approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 looks great, thanks

@amyrlam
Copy link
Member

amyrlam commented Jan 16, 2020 •
edited
Loading

getting alex errors on source/2019-01-26-emberjs-native-class-update-2019-edition.md, so going to merge in (i think they will go away upstream)

@amyrlam amyrlam merged commit 296bb29 into blog/embertimes-131 Jan 16, 2020
@amyrlam amyrlam deleted the chrisrng-patch-1 branch January 16, 2020 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyrlam amyrlam amyrlam approved these changes

Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisrng @amyrlam @jayjayjpg