Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Russian Ember community writeup #494

Merged
merged 5 commits into from
Jan 17, 2020
Merged

Add Russian Ember community writeup #494

merged 5 commits into from
Jan 17, 2020

Conversation

amyrlam
Copy link
Member

@amyrlam amyrlam commented Jan 17, 2020

FYI @chilicoder @lifeart, if you have any feedback!

@amyrlam amyrlam requested a review from a team January 17, 2020 01:37
@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Jan 17, 2020
ijlee2
ijlee2 approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for covering this! I think it'd be good to wait for feedback from Iaroslav or Alex before merging.

@amyrlam
Copy link
Member Author

amyrlam commented Jan 17, 2020

thanks @ijlee2 @chilicoder!

@amyrlam amyrlam merged commit efff3df into blog/embertimes-131 Jan 17, 2020
@amyrlam amyrlam deleted the amy/131-russian branch January 17, 2020 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarigpopov yarigpopov yarigpopov left review comments

@ijlee2 ijlee2 ijlee2 approved these changes

Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amyrlam @yarigpopov @ijlee2