Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding @MalayaliRobz's blog post on monorepo #550

Merged
merged 7 commits into from
Mar 3, 2020

Conversation

abhilashlr
Copy link
Member

@abhilashlr abhilashlr commented Mar 2, 2020

What it does

This PR adds @MalayaliRobz's blog post on "Splitting & Migrating your Ember project to a Monorepo" to the ember-times issue.

Sources

https://www.mylittletechlife.com/ember-monorepo

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Mar 2, 2020
Copy link
Contributor

@MinThaMie MinThaMie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cool write-up :) There a few things still missing.

You can add your name to the list at the top and the bottom of the post. Choose a cool emoji from a list like this: https://gist.github.com/rxaviers/7360908 to add to the title, and you can also add your title to the intro :)

source/2020-03-06-the-ember-times-issue-138.md Outdated Show resolved Hide resolved
@abhilashlr
Copy link
Member Author

@MinThaMie Addressed your review comments and I guess I did it right. If not please let me know what needs to be corrected.

Copy link
Contributor

@MinThaMie MinThaMie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed the emoji's for you :) You need to copy the actual emoji and not the key. I've learned that the hard way myself too!

source/2020-03-06-the-ember-times-issue-138.md Outdated Show resolved Hide resolved
source/2020-03-06-the-ember-times-issue-138.md Outdated Show resolved Hide resolved
source/2020-03-06-the-ember-times-issue-138.md Outdated Show resolved Hide resolved
abhilashlr and others added 2 commits March 3, 2020 18:32
Co-Authored-By: Anne-Greeth van Herwijnen <anne-greeth.vanherwijnen@nedap.com>
Copy link
Contributor

@MinThaMie MinThaMie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ijlee2
Copy link
Member

ijlee2 commented Mar 3, 2020

I'll go ahead and merge this PR.

@ijlee2 ijlee2 merged commit 3cee17c into ember-learn:blog/embertimes-138 Mar 3, 2020
@abhilashlr abhilashlr deleted the patch-1 branch March 4, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants