Skip to content

fix highlighting for code blocks with file names #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2021
Merged

fix highlighting for code blocks with file names #97

merged 2 commits into from
Mar 2, 2021

Conversation

lifeart
Copy link
Contributor

@lifeart lifeart commented Mar 1, 2021 •
edited
Loading

This mr fixes ingorrect code blocks highlighting, mentioned in related issue.

resolves #96

@lifeart lifeart marked this pull request as ready for review March 1, 2021 20:17
@lifeart lifeart changed the title fix higlighting fix highlighting for code blocks with file names Mar 1, 2021
sivakumar-kailasam
sivakumar-kailasam approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@sivakumar-kailasam sivakumar-kailasam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to add tests along with the fix 🙂

@sivakumar-kailasam
Copy link
Member

@jenweber this PR is good to merge

@jenweber
Copy link
Contributor

jenweber commented Mar 2, 2021

Thanks @lifeart and @sivakumar-kailasam !

@jenweber jenweber merged commit 9bd4e37 into ember-learn:master Mar 2, 2021
@lifeart lifeart deleted the fix-higlighting branch March 2, 2021 23:20
@lifeart lifeart mentioned this pull request Apr 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivakumar-kailasam sivakumar-kailasam sivakumar-kailasam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect syntax higligting
3 participants
@lifeart @sivakumar-kailasam @jenweber