Skip to content

Commit

Permalink
Merge pull request #488 from ember-learn/drop-node-14
Browse files Browse the repository at this point in the history
drop support for EOL node < 18
  • Loading branch information
mansona authored Oct 19, 2023
2 parents 15bae44 + 6c1aa57 commit b15f6a9
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 12 deletions.
15 changes: 5 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,8 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: 18.x
cache: npm
- run: npm i -g npm@8
- run: npm ci
- run: npx percy exec -- npm run test:docs

Expand All @@ -36,9 +35,8 @@ jobs:
- uses: mansona/npm-lockfile-version@v1
- uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: 18.x
cache: npm
- run: npm i -g npm@8
- run: npm ci
- run: npm run lint
- run: npx percy exec -- npm run test
Expand All @@ -51,9 +49,8 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: 18.x
cache: npm
- run: npm i -g npm@8
- run: npm install --no-shrinkwrap
- run: npm run test:ember

Expand Down Expand Up @@ -82,9 +79,8 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: 18.x
cache: npm
- run: npm i -g npm@8
- run: npm ci
- name: Run Tests
run: ./node_modules/.bin/ember try:one ${{ matrix.try-scenario }}
Expand All @@ -107,9 +103,8 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: 18.x
cache: npm
- run: npm i -g npm@8
- run: npm ci
- name: Run Tests
id: tests
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
"webpack": "^5.52.1"
},
"engines": {
"node": "12.* || 14.* || >= 16"
"node": "18.* || >= 20"
},
"ember": {
"edition": "octane"
Expand All @@ -120,6 +120,6 @@
"configPath": "tests/dummy/config"
},
"volta": {
"node": "16.20.1"
"node": "18.18.2"
}
}

0 comments on commit b15f6a9

Please sign in to comment.