Simplify EsHeaderComponent implementation.
#319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update the component to use Ember Octane API. - Remove the code for reseting `expanded` on CSS breakpoints for a more predictable behaviour and prevention of memory leaks. - Add `navbar-expanded` class to simplify styles and reduce coupling with HTML structure. - Fix accessibility warnings. - Add additional tests.
Author
Member
|
@alexeykostevich thanks for updating the PR 👍 it makes it much easier to review now 🎉 |
mansona
requested changes
Apr 29, 2020
Member
mansona
left a comment
mansona
left a comment
There was a problem hiding this comment.
I think this is a great simplification of a bunch of different parts of the component, just one request about using @tracked because of the current versions that we are trying to support but I don't think it will be super difficult to replace 👍
mansona
approved these changes
Apr 29, 2020
Member
|
@alexeykostevich thanks for doing this, and thanks for sticking with it 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expandedon CSS breakpoints fora more predictable behaviour and prevention of memory leaks.
navbar-expandedclass to simplify styles and reduce couplingwith HTML structure.