-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the browser support policy page #1088
Update the browser support policy page #1088
Conversation
✅ Deploy Preview for ember-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
app/templates/browser-support.hbs
Outdated
<h2>Ember 6.0.0</h2> | ||
|
||
<p> | ||
In Ember 6.0.0, the framework supports the following major browsers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ember 6 isn't out yet, so I'm not sure what we want to do here -- or maybe this whole section could be omitted until ember 6?
especially since the versions below on lines 16-19 are likely to change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe omit this section until 6.0 exists -- the policy below is enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment but I'm also "requesting changes" because we won't be merging this until ember@6 is released. We can keep this PR to remember that we need to merge it but it should be added to some sort of list of things to do for v6 👍
2175614
to
eefa8cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NullVoxPopuli mentions that he's not sure what to do about the future reference to an unreleased Ember version. I think we need to be very careful about how we phrase this. I'm requesting changes on this but I'm also committing to pair with @NullVoxPopuli to get the phrasing on this right 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is significantly improving the whole page and now effectively links to the future changes in the support policy 🎉
RFC: emberjs/rfcs#984