Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated title helper to page-title #716

Merged
merged 1 commit into from
Jan 12, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/templates/about/legal.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{title "Legal"}}
{{page-title "Legal"}}
<section class="container" aria-labelledby="legal">
<h1 id="legal">Legal</h1>
<p>
2 changes: 1 addition & 1 deletion app/templates/application.hbs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<HeadLayout />
Copy link
Member

@ijlee2 ijlee2 Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like deleting <HeadLayout> resulted in a breaking change for us. Previously, in https://deploy-preview-714--ember-website.netlify.app/, we could see 3 <meta> tags near the bottom of <head>:

Screen Shot 2021-01-12 at 6 38 59 PM

In https://deploy-preview-716--ember-website.netlify.app/, I'm unable to find these tags.

Now that ember-page-title no longer depends on ember-cli-head, I think we'll need to find another way to dynamically create these meta tags.

References:

Copy link
Member

@ijlee2 ijlee2 Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{{title "Ember.js"}}
{{page-title "Ember.js"}}

<BlackLivesMatterBanner />
<EmberSurvey />
2 changes: 1 addition & 1 deletion app/templates/community.hbs
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{{title "Community"}}
{{page-title "Community"}}

{{outlet}}
2 changes: 1 addition & 1 deletion app/templates/community/meetups-getting-started.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{title "Getting Started"}}
{{page-title "Getting Started"}}
<section class="container" aria-labelledby="getting-your-meetup-up-and-running">
<h1 id="getting-your-meetup-up-and-running">
Getting Your Meetup Up and Running
2 changes: 1 addition & 1 deletion app/templates/community/meetups/assets.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{title "Assets"}}
{{page-title "Assets"}}
<section class="container" aria-labelledby="ember-meetup-resources">
<h1 id="ember-meetup-resources">
Ember Meetup Resources
2 changes: 1 addition & 1 deletion app/templates/community/meetups/index.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{title "Meetups"}}
{{page-title "Meetups"}}
<div class="container">
<h1 class="mb-3">Meetups Around the World</h1>

2 changes: 1 addition & 1 deletion app/templates/editions/index.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{title "Editions"}}
{{page-title "Editions"}}
<section class="container" aria-labelledby="ember-editions">
<h1 id="ember-editions">Ember Editions</h1>
<p>
4 changes: 2 additions & 2 deletions app/templates/editions/octane.hbs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{title "Editions"}}
{{title "Octane"}}
{{page-title "Editions"}}
{{page-title "Octane"}}

<section class="container" aria-labelledby="octane-edition">
<h1>The Octane Edition of Ember</h1>
2 changes: 1 addition & 1 deletion app/templates/ember-community-survey-2016.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{title "Community Survey 2016"}}
{{page-title "Community Survey 2016"}}
<div class="bg-dark bg-shape-boxes">
<div class="container survey-header survey-container">

2 changes: 1 addition & 1 deletion app/templates/ember-community-survey-2017.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{title "Community Survey 2017"}}
{{page-title "Community Survey 2017"}}
<div class="bg-dark bg-shape-boxes">
<div class="container">

2 changes: 1 addition & 1 deletion app/templates/ember-community-survey-2018.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{title "Community Survey 2018"}}
{{page-title "Community Survey 2018"}}
<div class="bg-dark bg-shape-boxes">
<div class="container">

2 changes: 1 addition & 1 deletion app/templates/ember-community-survey-2019.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{title "Community Survey 2019"}}
{{page-title "Community Survey 2019"}}
<div class="bg-dark bg-shape-boxes">
<div class="container">
<h1>
2 changes: 1 addition & 1 deletion app/templates/ember-community-survey-2020.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{title "Community Survey 2020"}}
{{page-title "Community Survey 2020"}}

<div class="bg-dark bg-shape-boxes">
<div class="container">
2 changes: 1 addition & 1 deletion app/templates/ember-users.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{title "Who's Using Ember.js"}}
{{page-title "Who's Using Ember.js"}}
<section class="container" aria-labelledby="ember-users">
<div class="layout">
<div class="lg:col-4 lg:start-2 text-center text-muted mb-5">
2 changes: 1 addition & 1 deletion app/templates/guidelines.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{title "Community Guidelines"}}
{{page-title "Community Guidelines"}}
<div class="container layout">
<section class="lg:col-5" aria-labelledby="guidelines">
<h1 id="guidelines">Ember Community Guidelines</h1>
2 changes: 1 addition & 1 deletion app/templates/index.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{title "Ember.js - A framework for ambitious web developers" replace=true}}
{{page-title "Ember.js - A framework for ambitious web developers" replace=true}}

<section aria-labelledby="hero-title" class="bg-shape-boxes-bottom bg-dark">
<div class="container layout">
2 changes: 1 addition & 1 deletion app/templates/learn/index.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{title "Learn"}}
{{page-title "Learn"}}
<div class="container" aria-labelledby="learning-emberjs">
<h1 id="learning-emberjs">Learning Ember.js</h1>

2 changes: 1 addition & 1 deletion app/templates/logos.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{title "Branding"}}
{{page-title "Branding"}}
<div class="container">
<h1>Branding</h1>

2 changes: 1 addition & 1 deletion app/templates/mascots/index.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{title "Mascots"}}
{{page-title "Mascots"}}
<section aria-label="Mascots" class="container">
<h1>Tomster and Zoey</h1>
<p>
4 changes: 2 additions & 2 deletions app/templates/releases.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{title "Releases"}}
{{page-title "Releases"}}
<div class="container">
{{outlet}}
</div>
</div>
2 changes: 1 addition & 1 deletion app/templates/releases/beta.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{title "Beta"}}
{{page-title "Beta"}}

<ProjectListing
@channel="beta"
2 changes: 1 addition & 1 deletion app/templates/releases/canary.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{title "Canary"}}
{{page-title "Canary"}}

<h1 class="project-name">{{capitalize "canary"}} Channel</h1>

2 changes: 1 addition & 1 deletion app/templates/releases/lts.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{title "LTS"}}
{{page-title "LTS"}}

<ProjectListing
@projects={{array @model}}
2 changes: 1 addition & 1 deletion app/templates/releases/release.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{title "Stable"}}
{{page-title "Stable"}}

<ProjectListing
@projects={{array @model.ember @model.emberData}}
2 changes: 1 addition & 1 deletion app/templates/security.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{title "Security"}}
{{page-title "Security"}}
<div class="container layout">
<section class="lg:col-5" aria-labelledby="section-reporting-a-bug">
<h1>Ember.js Security Policy</h1>
2 changes: 1 addition & 1 deletion app/templates/sponsors.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{title "Sponsors"}}
{{page-title "Sponsors"}}
<section class="container" aria-labelledby="ember-sponsors-and-friends">
<h1 id="ember-sponsors-and-friends">
Ember Sponsors and Friends
2 changes: 1 addition & 1 deletion app/templates/team.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{title "Team"}}
{{page-title "Team"}}
<div class="container">
<h1 class="text-center">The Team Behind Ember</h1>
<section class="mb-3" aria-labelledby="team-detail">