Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show how to reference input event names correctly #1543

Closed
jenweber opened this issue Sep 27, 2020 · 1 comment · Fixed by #1546
Closed

Show how to reference input event names correctly #1543

jenweber opened this issue Sep 27, 2020 · 1 comment · Fixed by #1546
Assignees

Comments

@jenweber
Copy link
Contributor

jenweber commented Sep 27, 2020

In earlier versions of Ember, inputs had a bug where certain event names could not be referenced as they were documented in the Guides, such as <Textarea @focus-in={{this.didFocusIn}} />. This has been fixed now! We should update the Guides to make sure they give the correct guidance. This issue is recommended for writers with some past technical writing experience or past contributions to Ember's documentation.

To-do:

  • Try out the event passing like @focus-in in the latest stable version of Ember and confirm that it works
  • Read over https://guides.emberjs.com/release/components/built-in-components/ and see which examples/explanations should be updated. It is possible that no changes are needed, since the source of the confusion was that the Guides said something should work that didn't, and now there's a bugfix. If that's the case, please comment on this issue.
  • Feel free to open Issues for anything else you notice along the way that needs fixing
  • Reach out to the learning team on #dev-ember-learning if you have questions.

For reference:

Note that there are still some complexities that are not bugs which remain, such as understanding how action, fn, and modifiers fit into this story. Those are out of scope for this issue, since our first step should always be to make sure that the Guides are correct. If you are on a roll and want to tackle that too, go for it! For ease of review, please do separate PRs if you choose to keep going.

@jenweber
Copy link
Contributor Author

@ijlee2 is working on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants