[BUGFIX LTS] invoke methods correctly in TextSupport sendAction #19001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The introduction of the `attrs` API in Ember 3.13 included wrapping
items passed to components with `MutableCell`, to support two-way
binding. Although two-way binding is gone from much of Ember, the text
input components (`Input` and `Textarea`) continue to support it, via
the `TextSupport` mixins. The `sendAction` function used by the mixin
previously assumed that the only options were for an action to be a
string or a function -- not a function wrapped in a `MutableCell`.
The result was that this code, which would be expected to work, did not:
it would simply never be invoked.
<Textarea @Focus-In={{this.didFocusIn}} />
Accordingly, add logic to `sendAction` in `text_support.js` to unwrap a
mutable cell if it is set, and otherwise to carry on with the logic as
it was previously.
Backports the fix for #18994 (f16d174) to 3.16 LTS.
|
@rwjblue as promised! |
rwjblue
approved these changes
Jun 2, 2020
|
Thank you @chriskrycho! |
This was referenced Sep 27, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The introduction of the
attrsAPI in Ember 3.13 included wrapping items passed to components withMutableCell, to support two-way binding. Although two-way binding is gone from much of Ember, the text input components (InputandTextarea) continue to support it, via theTextSupportmixins. ThesendActionfunction used by the mixin previously assumed that the only options were for an action to be a string or a function -- not a function wrapped in aMutableCell.The result was that this code, which would be expected to work, did not: it would simply never be invoked.
Accordingly, add logic to
sendActionintext_support.jsto unwrap a mutable cell if it is set, and otherwise to carry on with the logic as it was previously.Backports the fix for #18994 (f16d174) to 3.16 LTS.