Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-cli-update v4.0.1...v4.4.1 #1985

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

bartocc
Copy link
Contributor

@bartocc bartocc commented Dec 15, 2023

ember-template-lint@4+ exists with status code 1 when there are no .hbs files to check, while ember-template-lint@3 exited with status code 0.

Since this repo does not contain any .hbs, let's just remove ember-template-lint and the related lint:hbs script

Copy link

netlify bot commented Dec 15, 2023

Deploy Preview for ember-guides ready!

Name Link
🔨 Latest commit d3d886c
🔍 Latest deploy log https://app.netlify.com/sites/ember-guides/deploys/657d661e254e480008894a3e
😎 Deploy Preview https://deploy-preview-1985--ember-guides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This repo does not contain any .hbs file so it does not need ember-template-lint and its related lint:hbs script
@bartocc bartocc marked this pull request as ready for review December 16, 2023 19:19
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉

@mansona mansona merged commit d3dded4 into ember-learn:master Dec 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants