Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OCTANE] rewrite text and example to use getters #578

Merged
merged 1 commit into from Mar 13, 2019
Merged

[OCTANE] rewrite text and example to use getters #578

merged 1 commit into from Mar 13, 2019

Conversation

ghost
Copy link

@ghost ghost commented Mar 11, 2019

Address #564

@ghost ghost changed the title rewrite text and example to use getters [OCTANE] rewrite text and example to use getters Mar 11, 2019
@jenweber
Copy link
Contributor

Thanks @efx for the changes and @rwjblue for reviewing!

@jenweber jenweber closed this Mar 13, 2019
@jenweber jenweber reopened this Mar 13, 2019
@jenweber jenweber merged commit 0a2dc07 into ember-learn:octane Mar 13, 2019
@ghost ghost deleted the fix-564 branch March 13, 2019 13:28
@jenweber jenweber mentioned this pull request Mar 15, 2019
Closed
lenoraporter pushed a commit to lenoraporter/guides-source that referenced this pull request Jul 19, 2020
@efx @lenoraporter
rewrite text and example to use getters (ember-learn#578)
09fbac6 
Address ember-learn#564
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenweber @rwjblue @eflanagan0