#588 components/actions-and-events #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
reviewed
Mar 15, 2019
| and its template. We've also seen how you can pass actual HTML attributes | ||
| forward, allowing you to customize the elements that components produce. | ||
| `input`s, `select`s, or `dialog`s and how components can use these argument values | ||
| for both their JavaScript and template. We've also seen how you can pass |
There was a problem hiding this comment.
Suggested change
| for both their JavaScript and template. We've also seen how you can pass | |
| in both their JavaScript and template. We've also seen how you can pass |
mixonic
approved these changes
Mar 15, 2019
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I learned a lot reading through this, I would like some review in the first paragraph. #588