#588 components/contextual-components #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
reviewed
Mar 15, 2019
| @@ -1,32 +1,32 @@ | |||
| The | |||
| [`{{component}}`](https://www.emberjs.com/api/ember/release/classes/Ember.Templates.helpers/methods/component?anchor=component) | |||
| helper can be used to defer the selection of a component to run time. The | |||
| `<MyComponent />` syntax always renders the same component, while using the | |||
| `<MyComponent/>` syntax always renders the same component, while using the | |||
There was a problem hiding this comment.
Ya, we should have a space here.
Suggested change
| `<MyComponent/>` syntax always renders the same component, while using the | |
| `<MyComponent />` syntax always renders the same component, while using the |
mixonic
approved these changes
Mar 15, 2019
rwjblue
reviewed
Mar 15, 2019
| @@ -1,32 +1,32 @@ | |||
| The | |||
| [`{{component}}`](https://www.emberjs.com/api/ember/release/classes/Ember.Templates.helpers/methods/component?anchor=component) | |||
| helper can be used to defer the selection of a component to run time. The | |||
| `<MyComponent />` syntax always renders the same component, while using the | |||
| `<MyComponent/>` syntax always renders the same component, while using the | |||
There was a problem hiding this comment.
Ya, we should have a space here.
Suggested change
| `<MyComponent/>` syntax always renders the same component, while using the | |
| `<MyComponent />` syntax always renders the same component, while using the |
| `{{component}}` helper allows choosing a component to render on the fly. This is | ||
| useful in cases where you want to interact with different external libraries | ||
| depending on the data. Using the `{{component}}` helper would allow you to keep | ||
| different logic well separated. | ||
|
|
||
| The first parameter of the helper is the name of a component to render, as a | ||
| string. So `{{component 'blog-post'}}` is the same as using `<BlogPost />`. | ||
| string. So `{{component 'blog-post'}}` is the same as using `<BlogPost/>`. |
There was a problem hiding this comment.
Suggested change
| string. So `{{component 'blog-post'}}` is the same as using `<BlogPost/>`. | |
| string. So `{{component 'blog-post'}}` is the same as using `<BlogPost />`. |
rwjblue
reviewed
Mar 15, 2019
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#588