Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review "configuring" (part one) #665

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Review "configuring" (part one) #665

merged 1 commit into from
Mar 18, 2019

Conversation

mixonic
Copy link
Contributor

@mixonic mixonic commented Mar 18, 2019

  • Configuring Your App - I did some serious re-wording here
  • Configuring Ember CLI - Left as is
  • Handling Deprecations - Just cleaned up a header. This should probably be reconsidered / balanced with the existence of the "upgrading/deprecations" guide entry.

@jenweber jenweber mentioned this pull request Mar 18, 2019
Closed
@mixonic mixonic requested a review from jenweber March 18, 2019 14:02
@acorncom
Copy link
Member

Thanks!

@acorncom acorncom merged commit de0bd2c into octane Mar 18, 2019
@acorncom acorncom deleted the mixonic/review branch March 18, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acorncom acorncom acorncom approved these changes

@jenweber jenweber Awaiting requested review from jenweber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mixonic @acorncom