Adds ember engines in "Application Concerns" #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenweber
reviewed
Apr 23, 2019
Co-Authored-By: villander <nousvillander@gmail.com>
Co-Authored-By: villander <nousvillander@gmail.com>
|
I applied all suggested changes, thanks so much @jenweber |
jenweber
approved these changes
Apr 26, 2019
There was a problem hiding this comment.
This is ready to go now!
I raised the question of file naming and TOC placement with the learning team a couple days ago. It seems that ember-engines makes sense as the file name/url because there is not really a more general concept to use here. It's about the name of the library, the same as how we renamed "Models" to "Ember Data."
There were no objections to the merge in general, since there was already good cautionary info in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's solves the big problem around ember ecosystem #701 - this will increase our visibility and the actual proposal of ember engines in ember ecosystem and de-emphasize code-splitting/lazy-loading a bit.
cc: @MelSumner @locks @jenweber @acorncom