New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro-based ember version check #184

Merged

ef4 merged 3 commits into main from dependency-satisfies-check

Sep 16, 2022

Contributor

ef4 commented Sep 16, 2022 •

edited

Loading

make the polyfill inert on Ember versions that don't need it (>= 4.1)
delegate this decision to @embroider/macros, so it's safe to run this polyfill's babel plugin on a v2 addon before publishing to NPM.

ef4 added 2 commits

September 16, 2022 02:39


          implement a dependencySatisfies check

7176d72


          add exports key

7cbba8b

ef4 added the enhancement label


          document babel plugin

5532da8

ef4 merged commit 5cfa048 into main

ef4 deleted the dependency-satisfies-check branch

September 16, 2022 08:05

simonihmig mentioned this pull request

Using polyfill when addon is not declaring a (peer) dependency on ember-source #212

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels