fix: Allow the babel plugin to be registered for addons

[dcyriller]

Description

This PR would fix the case when @cached is used in an addon.

When ember-cached-decorator-polyfill is used in an addon... Currently the babel polyfill is registered for the host app. So, adding the polyfill to the addon's package.json file doesn't allow the @cached transpilation to happen.

This PR would allow the babel plugin to be registered for the addon instead.

Links

If merged, this PR would make emberjs/data#7599 possible.
It would fix concordnow/ember-aria-tabs#218.
It might fix (I'm not sure) #75 (comment).

[simonihmig]

I ran into TypeError: decorator is not a function when using this in an addon, and was lucky to see this PR has already been raised - thanks @dcyriller!. Using this branch in my addon fixed this problem! 🎉

I think the change here is correct, and having enabled CI now - which is green - seems to confirm this. Although technically I have the privileges to merge, I would rather want someone else to have a 2nd pair of  👀 /cc @rwjblue

[void-mAlex]

following this change I've started encountering #97
can someone clarify if that is intended?

[NullVoxPopuli]

@void-mAlex I'm experiencing #97 as well.

[void-mAlex]

@NullVoxPopuli from the minimal digging I've done I think it might be a case where the app importing the addon has other dependencies that pull in older versions of 'ember-cli-babel' (and maybe related to #81 (comment)).
sorry if this is ends up being red herring

[NullVoxPopuli]

hmm, that might be much harder to track down. we have a lot of deps

[RobbieTheWagner]

0.1.4 should have been a 0.2.0 or 1.0.0 as this was a breaking change for addon authors.

[RobbieTheWagner]

Does anyone have a fix for the TypeError: decorator is not a function error?

[simonihmig]

I read #97 as an issue, where the app is using @cached while it didn't have the polyfill as a direct dependency. If that is the case, then I think @dcyriller comment is correct.

0.1.4 should have been a 0.2.0 or 1.0.0 as this was a breaking change for addon authors.

Again, if the above is true, then I would disagree. If things break, then because people were accidentally relying on the buggy behavior before the latest release. But that's strictly speaking not a SemVer breaking change. (yes, I see that it can feel as such)

[RobbieTheWagner]

Even after removing ember-cached-decorator-polyfill from the addon and installing in our app, I get TypeError: decorator is not a function. I had to downgrade to 0.1.1.

[knownasilya]

I was able to get this working in ember-flow by moving it to dependencies (addon with 3.28 ember-cli-update)