Skip to content
This repository has been archived by the owner on Aug 3, 2020. It is now read-only.

Become a "real" polyfill. #5

Closed
3 of 4 tasks
rwjblue opened this issue Nov 8, 2016 · 5 comments
Closed
3 of 4 tasks

Become a "real" polyfill. #5

rwjblue opened this issue Nov 8, 2016 · 5 comments

Comments

@rwjblue
Copy link
Member

rwjblue commented Nov 8, 2016

Basic steps:

  • Monkey patch Ember.getOwner when Ember version is too old
  • Deprecate usage of import getOwner from 'ember-getowner-polyfill';, in favor of just using Ember.getOwner
  • Bump major versions, remove deprecated import support.
  • Work on common/top addons to update to latest version (ongoing)
@rwjblue
Copy link
Member Author

rwjblue commented Nov 8, 2016

/cc @nathanhammond

@workmanw
Copy link

workmanw commented Dec 7, 2016

@rwjblue

Bump major versions, remove deprecated import support.

Does this mean you would prefer for addons to wait on PRs until after this addon is 2.x? I just submitted a PR to ember-i18n to remove deprecations from my builds. But now I'm wondering if I should pause that until this addon is 2.x? Thoughts? Timeline for that?

@rwjblue
Copy link
Member Author

rwjblue commented Dec 7, 2016

Does this mean you would prefer for addons to wait on PRs until after this addon is 2.x?

@workmanw - No, I think we need to let things settle a bit before I release 2.0.0. Sadly, this will be some churn for addons but the bump from 1.1.0 to 2.0.0 will not introduce deprecations, so it should be a simple package.json bump when the time comes.

@rwjblue
Copy link
Member Author

rwjblue commented May 18, 2017

Looks like still a few addons needing to be updated https://emberobserver.com/code-search?codeQuery=import.*ember-getowner-polyfill&regex=true

@rwjblue
Copy link
Member Author

rwjblue commented Jul 28, 2017

Done and published.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants