Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning about ember-getowner-polyfill after upgrading to Ember v2.12.1 #160

Closed
localpcguy opened this issue Apr 11, 2017 · 1 comment

Comments

@localpcguy
Copy link

localpcguy commented Apr 11, 2017

Got the following deprecation notice after upgrading Ember to v2.12.1 (from v2.9.x).

DEPRECATION: ember-getowner-polyfill is now a true polyfill. Use Ember.getOwner directly instead of importing from ember-getowner-polyfill

ember-polyfills/ember-getowner-polyfill#5

Looks like possibly the version of ember-getowner-polyfill just needs to be bumped to the latest version?

@localpcguy localpcguy changed the title DEPRECATION: ember-getowner-polyfill - after upgrading to Ember v2.12.1 from v2.9.x Deprecation warning about ember-getowner-polyfill after upgrading to Ember v2.12.1 from v2.9.x Apr 11, 2017
@localpcguy localpcguy changed the title Deprecation warning about ember-getowner-polyfill after upgrading to Ember v2.12.1 from v2.9.x Deprecation warning about ember-getowner-polyfill after upgrading to Ember v2.12.1 Apr 11, 2017
@runspired runspired mentioned this issue Apr 24, 2017
8 tasks
@rwjblue
Copy link
Contributor

rwjblue commented May 18, 2017

The solution is to remove this line https://github.com/runspired/smoke-and-mirrors/blob/a0747f790d19bea0572c7a875eb4cdcab56f07de/addon/components/vertical-item/component.js#L3 and add:

const { getOwner } = Ember;

Then bump the polyfill to the latest 1.x version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants