Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TESTS]: wrote a full redux-saga example w/ middleware #26

Merged
merged 1 commit into from
Oct 14, 2016

Conversation

toranb
Copy link
Collaborator

@toranb toranb commented Oct 14, 2016

No description provided.

@toranb
Copy link
Collaborator Author

toranb commented Oct 14, 2016

@cafreeman I wrote a simple patch that helps prove redux-saga is supported (along w/ your custom middleware setup method). I realize it doesn't include any proof that the store is passed like redux-observable needs but I figure we could patch this in w/ a dual middleware (like you showed in your example).

This look good to you? It's not a "running test" just yet as I planned to merge this (after you look it over) and then you can rebase/ rename it to zmiddleware-test.js and watch it go green :)

@cafreeman
Copy link
Contributor

@toranb this looks great! Let's merge it!

@toranb toranb merged commit e38bdf8 into master Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants