Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show invisible characters in replacement fix #261

Merged
merged 1 commit into from
May 30, 2023
Merged

Show invisible characters in replacement fix #261

merged 1 commit into from
May 30, 2023

Conversation

patricklx
Copy link
Contributor

No description provided.

@bmish
Copy link
Member

bmish commented May 29, 2023

  1. Can you explain this a bit more. "invisibles"?
  2. Can we add a test?

@patricklx
Copy link
Contributor Author

patricklx commented May 30, 2023 •
edited
Loading

  1. i think the invisibles are spaces and newlines, they will be replaced with ⏎·, thats how its done for the other parts with the function showInvisibles

@bmish bmish added the bug Something isn't working label May 30, 2023
@bmish bmish changed the title fix replace message not showing invisibles Showing invisible characters in replacement fix May 30, 2023
@bmish bmish changed the title Showing invisible characters in replacement fix Show invisible characters in replacement fix May 30, 2023
bmish
bmish approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmish bmish merged commit a4c36bd into ember-template-lint:main May 30, 2023
@patricklx patricklx deleted the patch-1 branch May 30, 2023 15:42
@dcyriller
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmish bmish bmish approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patricklx @bmish @dcyriller