Fix infinite recursion when printing sub-nodes #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courajs
changed the title
- Test proving that when you reuse parts from previous concat statement in new concat statement you will get "Maximum callstack size exceeded"
…verflow - Seems like anything that comes out of `parse()` apart from the whole object will trigger the stack overflow.
Fixes ember-template-lint#586 Previously, calling print on node that came from our parse(), but was not the top-level node, would cause infinite recursion. (It would have NodeInfo, but not a registered parse result). This fixes the infinite loop, by just storing a reference to the top-level parse result in the node info, and using that. Importantly, this successfully preserves formatting for any sub-nodes we did parse ourselves, or any user-created nodes that require custom printing.
courajs
force-pushed
the
fix-586-infinite-recursion-printing-subnodes
branch
from
767302c to
d9d9f5d
Compare
dcyriller
approved these changes
Nov 17, 2021
|
@courajs Seems like this one got approved. Can we have a merge? |
A good question for someone with write access :) |
|
Thanks a lot both of you! |
|
It is released in v6.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built starting from #653, so that should be merged first. For an easier code review, look at the diff against that branchFixes #586
Includes test from #586, with some expanded coverage and a different fix.