Update Typescript configuration #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now target Nodejs 12. So we can change the target to `es2019`. (for reference, see: https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping#node-12)
As a result, we restrict build-in type declarations to es2019 and dom. Adding `es2019` and `dom` groups to the list of built-in type declarations is the minimum set we need. Why do we need this change? In a follow-up, we will add `es2020.string` to the list. It will allow us to use String.matchAll which is also supported in Nodejs 12.
rwjblue
approved these changes
Nov 19, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We now target Nodejs 12. So we can change the tsconfig.json's target to
es2019(for reference, see:https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping#node-12)
Add the
libfield in tsconfig.json. As a result, we restrict build-in type declarations toes2019anddom. Adding these two groups seem to be the minimal requirement to add thelibfield.Why do we need this change?
In a follow-up, we will add
es2020.stringto thelibfield It will allow us to use String.matchAll which is also supported in Nodejs 12.