Skip to content

Scope to JS and TS #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Scope to JS and TS #8

wants to merge 1 commit into from

Conversation

evoactivity
Copy link
Member

VSCode determines the language to filter snippets by from the caret position in a file. Inside a GTS or GJS file the outer scope is "typescript" and "javascript" respectively.

Originally tried changing this so the outer scope language was glimmer-ts or glimmer-js but this caused the js/ts language features to never activate for a gts/gjs file.

…js files

+semver: patch
@NullVoxPopuli
Copy link
Member

I wonder if we should publish two packages?

one for vscode, one for not-vscode?

that way there are no compromises. hmm

@evoactivity
Copy link
Member Author

Probably best option for forseeable future.

We can generate a different package.json with some argument to the generate script.

I'm not familiar with publishing for neovim, is that something we can automate?

@NullVoxPopuli
Copy link
Member

I'm not familiar with publishing for neovim, is that something we can automate?

neovim uses git references directly, so we'd probably make a separate branch and tags for neovim publishes, and then instructions would be like:

use { 'ember-tooling/snippets', branch = 'neovim-1.x' }
-- or
use { 'emebr-tooling/snippets', tag = 'neovim@1.2.3' }

or something like that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants