Force to request absinfo also onmultitouch axes #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dev before me left a comment on handling that later. Not sure if there is any special case that needed to be implemented which I now completly ignored.
LinusCDE
referenced
this pull request
in canselcik/libremarkable
Dec 25, 2020
emberian
approved these changes
Dec 25, 2020
|
i think "handle this later" meant i was going to expose mt separately somehow, i don't really remember :) |
|
Thanks for the quick response. As soon as this is up on crates.io, we can finally ship libremarkable again. 👍 |
|
@LinusCDE i've released 0.10.2. i also spent some time trying to update the deps but this crate is ancient and creaky at this point! |
|
Thanks! No problem. Having old versions is a blessing as well as a curse. Have the problem with tokio for a project. Can't even get it to 0.3 without some dependencies crying bloody murder. One dependency even forced me to use tokio 0.1 to use it. Took an eternity to figure out, but that was still faster than replacing the dependency completely. And updating it myself went horribly wrong for me. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I already asked in issue #20 why the multitouch axes were intentionally ignored when requesting axes.
The changes, I noted there, were added to libremarkable (a library to use the hardware of the reMarkable Gen 1 and working on Gen 2) so we can get the size of the multitouch screen for any device generation and do not need to hardcode the sizes which will make future updates easier.
Now, it turned out, that we can't just refer to my fork and publish this on crates.io (related discussion that cause this PR). (I initially thought, waiting on the issue to get response after some months would be enough.)
I still don't know whether it has any side effects, but the changes didn't cause any noticed side effects for us, so I would presume it safe. I would be cool, if this could be merged soon and get a new version on crates.io, we can refer to, to be able to publish a new version of libremarkable again.