fix: live-array delete sync should not clear the set on length match (#…

…8927) (#8926) * fix: add test for unloadAll not fully cleaning up * fix * fix lint
emberjs · Sep 28, 2023 · 7c5c65a · 7c5c65a
1 parent 9ec3d59
commit 7c5c65a
Show file tree

Hide file tree

Showing 2 changed files with 396 additions and 1 deletion.
diff --git a/packages/store/src/-private/managers/record-array-manager.ts b/packages/store/src/-private/managers/record-array-manager.ts
@@ -405,13 +405,13 @@ function sync(
     } else {
       if (arraySet.has(key)) {
         removes.push(key);
+        arraySet.delete(key);
       }
     }
   });
   if (removes.length) {
     if (removes.length === state.length) {
       state.length = 0;
-      arraySet.clear();
       // changing the reference breaks the Proxy
       // state = array[SOURCE] = [];
     } else {