Add test that legacy schema records cannot access resource fields

emberjs · Nov 10, 2023 · 8ec3207 · 8ec3207
1 parent c5b63d2
commit 8ec3207
Show file tree

Hide file tree

Showing 2 changed files with 65 additions and 1 deletion.
diff --git a/packages/schema-record/src/record.ts b/packages/schema-record/src/record.ts
@@ -235,7 +235,6 @@ export class SchemaRecord {
             entangleSignal(signals, receiver, field.name);
             return computeAttribute(cache, identifier, prop as string);
           case 'resource':
-            // FIXME: Needs test for assertion
             assert(
               `SchemaRecord.${field.name} is not available in legacy mode because it has type '${field.kind}'`,
               !target[Legacy]

diff --git a/tests/warp-drive__schema-record/tests/legacy/mode-test.ts b/tests/warp-drive__schema-record/tests/legacy/mode-test.ts
@@ -248,4 +248,69 @@ module('Legacy Mode', function (hooks) {
       );
     }
   });
+
+  test('records in legacy mode cannot access resources', function (assert) {
+    const store = this.owner.lookup('service:store') as Store;
+    const schema = new SchemaService();
+    store.registerSchema(schema);
+
+    schema.defineSchema('user', {
+      legacy: true,
+      fields: [
+        {
+          name: 'name',
+          type: null,
+          kind: 'attribute',
+        },
+        {
+          name: 'bestFriend',
+          type: 'user',
+          kind: 'resource',
+          options: { inverse: 'bestFriend', async: true },
+        },
+      ],
+    });
+
+    const record = store.push({
+      data: {
+        type: 'user',
+        id: '1',
+        attributes: {
+          name: 'Chris',
+        },
+        relationships: {
+          bestFriend: {
+            data: { type: 'user', id: '2' },
+          },
+        },
+      },
+      included: [
+        {
+          type: 'user',
+          id: '2',
+          attributes: {
+            name: 'Rey',
+          },
+          relationships: {
+            bestFriend: {
+              data: { type: 'user', id: '1' },
+            },
+          },
+        },
+      ],
+    }) as User;
+
+    assert.true(record[Legacy], 'record is in legacy mode');
+
+    try {
+      record.bestFriend;
+      assert.ok(false, 'record.bestFriend should throw');
+    } catch (e) {
+      assert.strictEqual(
+        (e as Error).message,
+        "Assertion Failed: SchemaRecord.bestFriend is not available in legacy mode because it has type 'resource'",
+        'record.bestFriend throws'
+      );
+    }
+  });
 });