Don't expose the value of a model's attribute in assertions (#7370)

* don't expose the value of a model's attribute in production builds
emberjs · Nov 30, 2020 · 9b7936a · 9b7936a
1 parent 4fc1b07
commit 9b7936a
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 4 deletions.
diff --git a/packages/-ember-data/tests/unit/model-test.js b/packages/-ember-data/tests/unit/model-test.js
@@ -1,6 +1,7 @@
 import { computed, get, observer, set } from '@ember/object';
 import { guidFor } from '@ember/object/internals';
 import { settled } from '@ember/test-helpers';
+import { DEBUG } from '@glimmer/env';
 
 import { module, test } from 'qunit';
 import { reject, resolve } from 'rsvp';
@@ -141,9 +142,23 @@ module('unit/model - Model', function(hooks) {
         'the deleted person is not removed from store (no unload called)'
       );
 
-      assert.expectAssertion(() => {
-        set(record, 'isArchived', true);
-      }, /Attempted to set 'isArchived' to 'true' on the deleted record <person:1>/);
+      if (DEBUG) {
+        assert.throws(
+          () => {
+            set(record, 'isArchived', true);
+          },
+          /Attempted to set 'isArchived' to 'true' on the deleted record <person:1>/,
+          'Assertion includes more context when in DEBUG'
+        );
+      } else {
+        assert.throws(
+          () => {
+            set(record, 'isArchived', true);
+          },
+          /Attempted to set 'isArchived' on the deleted record <person:1>/,
+          "Assertion does not leak the 'value'"
+        );
+      }
 
       currentState = record._internalModel.currentState;
 

diff --git a/packages/store/addon/-private/system/model/internal-model.ts b/packages/store/addon/-private/system/model/internal-model.ts
@@ -934,7 +934,11 @@ export default class InternalModel {
 
   setDirtyAttribute(key, value) {
     if (this.isDeleted()) {
-      throw new EmberError(`Attempted to set '${key}' to '${value}' on the deleted record ${this}`);
+      if (DEBUG) {
+        throw new EmberError(`Attempted to set '${key}' to '${value}' on the deleted record ${this}`);
+      } else {
+        throw new EmberError(`Attempted to set '${key}' on the deleted record ${this}`);
+      }
     }
 
     let currentValue = this.getAttributeValue(key);