Skip to content

Commit

Permalink
chore: remove instance initializer (#7228)
Browse files Browse the repository at this point in the history
* chore: remove instance initializer

* fix DAG
  • Loading branch information
runspired authored Jun 15, 2020
1 parent 89b630f commit ab249ee
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 25 deletions.
2 changes: 0 additions & 2 deletions packages/-ember-data/addon/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ import {
RootState,
Snapshot,
} from './-private';
import initializeStoreService from './initialize-store-service';
import setupContainer from './setup-container';

if (VERSION.match(/^1\.([0-9]|1[0-2])\./)) {
Expand Down Expand Up @@ -117,7 +116,6 @@ DS.hasMany = hasMany;
DS.Relationship = Relationship;

DS._setupContainer = setupContainer;
DS._initializeStoreService = initializeStoreService;

Object.defineProperty(DS, 'normalizeModelName', {
enumerable: true,
Expand Down
15 changes: 0 additions & 15 deletions packages/-ember-data/addon/initialize-store-service.js

This file was deleted.

5 changes: 2 additions & 3 deletions packages/-ember-data/app/instance-initializers/ember-data.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import initializeStoreService from 'ember-data/initialize-store-service';

/* exists only for things that historically used "after" or "before" */
export default {
name: 'ember-data',
initialize: initializeStoreService,
initialize() {},
};
6 changes: 1 addition & 5 deletions packages/-ember-data/tests/integration/application-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import Service, { inject as service } from '@ember/service';

import { module, test } from 'qunit';

import initializeStoreService from 'ember-data/initialize-store-service';
import initializeEmberData from 'ember-data/setup-container';
import Store from 'ember-data/store';
import { setupTest } from 'ember-qunit';
Expand Down Expand Up @@ -105,10 +104,7 @@ module('integration/application - Attaching initializer', function(hooks) {
name: 'ember-data',
initialize: initializeEmberData,
});
this.TestApplication.instanceInitializer({
name: 'ember-data',
initialize: initializeStoreService,
});

this.application = null;
this.owner = null;
});
Expand Down

0 comments on commit ab249ee

Please sign in to comment.