Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate assertions thrown from ED despite App.reset in tests #2112

Closed
jmdfm opened this issue Jul 23, 2014 · 3 comments
Closed

Alternate assertions thrown from ED despite App.reset in tests #2112

jmdfm opened this issue Jul 23, 2014 · 3 comments

Comments

@jmdfm
Copy link
Contributor

jmdfm commented Jul 23, 2014

I'm seeing an issue in this JSBIN http://jsbin.com/rajikike/2/edit where it looks like the store is not being reset when I call App.reset().

If you click Run JS several times you'll see the assertion, all green, assertion... and so on.

The assertion is: TypeError: 'undefined' is not an object (evaluating 'data.links')

[Debug] DEBUG: ------------------------------- (ember.js, line 3911)
[Debug] DEBUG: Ember      : 1.6.1 (ember.js, line 3911)
[Debug] DEBUG: Ember Data : 1.0.0-beta.8.2a68c63a (ember.js, line 3911)
[Debug] DEBUG: Handlebars : 1.2.1 (ember.js, line 3911)
[Debug] DEBUG: jQuery     : 1.10.2 (ember.js, line 3911)
[Debug] DEBUG: ------------------------------- (ember.js, line 3911)
@bmac
Copy link
Member

bmac commented Jul 25, 2014

This looks to me like a bug in ember-qunit not Ember Data. I opened an issue on that repo to confirm https://github.com/rwjblue/ember-qunit/issues/81. But it looks to me like the this.subject() helper is keeping a reference to a shared container for all the tests.

@jmdfm
Copy link
Contributor Author

jmdfm commented Jul 25, 2014

I did originally have it open on ember-qunit, but after talking with @rwjblue on IRC he seemed to think it belonged here.

@rwjblue
Copy link
Member

rwjblue commented Jul 29, 2014

Looks like @bmac pin-pointed the issue (thank you!). Closing here, in favor of fixing it in ember-qunit. If I find additional problems while fixing that issue, I'll refile.

@rwjblue rwjblue closed this as completed Jul 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants