subject helper in moduleForModel reuses container for all tests

[bmac]

While attempting to debug this jsbin from emberjs/data#2112 I noticed this check seems to cause this.subject() to reuse the same container for all the tests in a module. Is that intentional?

[rwjblue]

Thank you for tracking this down. I'm working on some internal refactoring (mostly build related), and will tackle this once that is done.

[givanse]

What would be the workaround for this? How do I instantiate my own objects instead of using this.subject?

[shturm]

Same behavior for testing controllers. As temporary workaround I invoke a function which clears the parent scope (subject) properties which I need. Good to know it's not intentional

[bantic]

We just ran into an issue that seems related to this where the store instance leaked between tests. In the second test a model.reload() promise was silently failing to ever settle because a check in ED for whether the store isDestroyed or isDestroying returned true (because the store was the same instance as the one that had been destroyed in the previous test).

We worked around it by using this.store() and calling createRecord directly instead of using this.subject:

// bad, could reuse the store instance
var model = this.subject();

// good, avoids reusing store
var model = Ember.run(this, function(){
  return this.store().createRecord('my-model-name', options);
});

[bmac]

Fixed by emberjs/ember-test-helpers#28.