store.find('model', ''); shouldn't query 'api/models/'

[calvinmetcalf]

basically if you do find with an empty string then it does a search for api/models/ with no id which leads to it downloading all of the models, coerceID seems like it should be coercing empty strings to null.

[stefanpenner]

is this still an issue on master? I seem to remember @raycohen fixing this ages ago. Maybe a regression?

[calvinmetcalf]

canary definitely not sure about master

[stefanpenner]

maybe something funky with the new batching code?

my quick skim yields the following code-path:

1. https://github.com/emberjs/data/blob/master/packages/ember-data/lib/system/store.js#L418
2. https://github.com/emberjs/data/blob/master/packages/ember-data/lib/system/store.js#L431
3. https://github.com/emberjs/data/blob/master/packages/ember-data/lib/system/store.js#L452
4. https://github.com/emberjs/data/blob/master/packages/ember-data/lib/system/store.js#L515

which doesn't appear to suffer from this (at least not at first glance). Maybe ^^ will give you enough context to track down the failure.

[calvinmetcalf]

at no place in that path does it bother to check if it is an empty string

[igorT]

Sorry for the late followup, but I am not sure what is the use case for passing an empty string? Would you expect it to immediately reject?

[raycohen]

The (unmerged) PR @stefanpenner recalls is #518

I agree with @lukemelia's comment found in the discussion.

[igorT]

My bad. We deprecated the overloaded find but should still add the assert
On May 24, 2015 8:02 PM, "Ray Cohen" notifications@github.com wrote:

The (unmerged) PR @stefanpenner https://github.com/stefanpenner recalls
is #518 #518

I agree with @lukemelia https://github.com/lukemelia's comment found in
the discussion.

—
Reply to this email directly or view it on GitHub
#2348 (comment).