Embedded polymorphic record with custom id doesn't work.

[mayatskiy]

If I have embedded polymorphic records and a custom primaryKey (for example '_id').
When I use EmbeddedRecordsMixin this code works incorrectly:

function extractEmbeddedHasManyPolymorphic(store, key, hash) {
  ...
  forEach(hash[key], function(data) {
    var typeKey = data.type;
    var embeddedSerializer = store.serializerFor(typeKey);
    var embeddedType = store.modelFor(typeKey);
    var primaryKey = get(embeddedSerializer, 'primaryKey'); // returns '_id'

    var embeddedRecord = embeddedSerializer.normalize(embeddedType, data, null);
    store.push(embeddedType, embeddedRecord);
    ids.push({ id: embeddedRecord[primaryKey], type: typeKey }); // the error is here
  });

next line:

   ids.push({ id: embeddedRecord[primaryKey], type: typeKey });

sets undefined id. Because embeddedRecord has no '_id' key after deserialization and have only 'id' key.

[lolmaus]

Hey @mayatskiy, i'm using polymorphic embedded records successfully. Can you please reproduce the issue on http://emberjs.jsbin.com/ ?

[mayatskiy]

@lolmaus with custom id?

[lolmaus]

@mayatskiy, my polymorphic records are treated by the backend as nested attributes rather than child records. They arrive without ids.

I override the extractArray, extractSingle and serialize methods of the parent model serializer and slip ids into the polymorphic items.

[bmac]

Thanks for the bug report @mayatskiy. Would you like to open a pr to fix this issue?

[igorT]

@pangratz wanna take a stab at this? Shouldn't be too hard, we in fact don't need to worry about the primary key here because we already normalized, so if you just remove those couple lines + a test would be good to go

[pangratz]

@igorT I will take a stab at it tomorrow

[igorT]

Fixed by #3138