Custom primaryKey for embedded polymorphic relations work #3138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the hashs of the polymorphic embedded records are normalized, the - possible - customized primaryKey can be accessed via the `id` property.
| color: "Red" | ||
| }, | ||
| { | ||
| id: "1", |
There was a problem hiding this comment.
😯 – The primaryKey is only defined for the serializer:light-saber. If both embedded records should have custom as primaryKey, it would/could be defined in serializer:secret-weapon.
Am I missing something? 😔 💭
There was a problem hiding this comment.
I could add a comment since I guess this would make reading the test easier ... c/d?
|
Thanks! |
|
@mayatskiy since you originally reported the issue in #2793, can you check the test cases in this PR and confirm that they are the ones you had/have issues with? |
igorT
added a commit
that referenced
this pull request
Jun 1, 2015
Custom primaryKey for embedded polymorphic relations work
|
Thanks! |
|
👯 |
|
@pangratz yes, I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the hashs of the polymorphic embedded records are normalized, the - possible - customized primaryKey can be accessed via the
idproperty.This addresses #2793.
cc @igorT