Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming DS.Snapshot #3285

Closed
igorT opened this issue Jun 10, 2015 · 1 comment
Closed

Consider renaming DS.Snapshot #3285

igorT opened this issue Jun 10, 2015 · 1 comment

Comments

@igorT
Copy link
Member

igorT commented Jun 10, 2015

Snapshots are becoming a primary tool for communication between the store and adapter. However Snapshot is a pretty confusing name. Can we come up with a better one. I tried AdapterSnapshot to indicated it's meant to be passed to adapter/serializer only, but it's a bad name as it's not a Snapshot of an Adapter
@HeroicEric HeroicEric mentioned this issue Jun 10, 2015
Closed
1 task
@igorT igorT changed the title Rename Snapshot to AdapterSnapshot Consider renaming DS.Snapshot Jun 11, 2015
@igorT igorT mentioned this issue Jun 11, 2015
Closed
10 tasks
@fivetanley
Copy link
Member

We decided to not move on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename Snapshot to AdapterSnapshot HeroicEric/data
2 participants
@igorT @fivetanley