Rename Snapshot to AdapterSnapshot

[HeroicEric]

fixes #3285

• Rename Snapshot to AdapterSnapshot

[igorT]

record._createSnapshot is private no need to deprecate

[HeroicEric]

@igorT I was just thinking it might be nice since there are some popular addons that are using it.

• https://github.com/lytics/ember-data.model-fragments
• https://github.com/kurko/ember-json-api
• https://github.com/clintjhill/ember-parse-adapter

to name a few

[igorT]

well end up with a public hook later, so would rather not rename fo rnow

On Thu, Jun 11, 2015 at 1:58 AM, Eric Kelly notifications@github.com
wrote:

@igorT https://github.com/igorT I was just thinking it might be nice
since there are some popular addons that are using it.

• https://github.com/lytics/ember-data.model-fragments
• https://github.com/kurko/ember-json-api
• https://github.com/clintjhill/ember-parse-adapter

to name a few

—
Reply to this email directly or view it on GitHub
#3294 (comment).

[HeroicEric]

You'd rather not rename Snapshot or Model._createSnapshot()?

[igorT]

_createsnapshot
On Jun 10, 2015 4:29 PM, "Eric Kelly" notifications@github.com wrote:

You'd rather not rename Snapshot or Model#_createSnapshot?

—
Reply to this email directly or view it on GitHub
#3294 (comment).

[bmac]

Thanks for the pr @HeroicEric. Unfortunately, the Ember Data team has decided to stick with the name Snapshot.