store.push can't handle top-level JSON API types being plural

[kagemusha]

Looking the jsonapi format doc seems top-level types should be plural, yet store.push fails when you pass plurals.

Failure is at the modelFor call in _pushInternalModel fn in store

As plurals work fine for store.findRecords, shouldn't they work here too?

[bmac]

@kagemusha Try using store.pushPayload instead of push. push currently expects the top level keys to be singular and the relationship and attribute names to be match the names defined on your record.

The JSONAPISerializer automatically singularizes the type and undasherizes the attribute and relationship names when it runs on the payload returned by store.findRecord.

store.pushPayload runs the payload through the serializer before passing it to store.push.

[bmac]

@wecc Maybe we should assert that ED can lookup the type in store.push with a message instructing people to use store.pushPayload instead if that fails.

[kagemusha]

@bmac thanks, that works. Thought i read somewhere that pushPayload gonna be deprecated at some point and everything will go thru push in future. In that the case?

[wecc]

@bmac agree, I think we should assert that type is found in _pushInternalModel

Edit: #3542

[kagemusha]

@bmac @wecc Won't ember data types always be singular? Why not singularize here instead (or in addition) to the assert?