Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert that type is found when doing store.push #3542

Closed
wecc opened this issue Jul 13, 2015 · 1 comment
Closed

Assert that type is found when doing store.push #3542

wecc opened this issue Jul 13, 2015 · 1 comment

Comments

@wecc
Copy link
Contributor

wecc commented Jul 13, 2015

We should add an assert in store._pushInternalModel checking that type is found.
@wecc wecc mentioned this issue Jul 13, 2015
Closed
@Serabe
Copy link
Member

Serabe commented Jul 13, 2015

store.modelFor raises an Ember.Error if no model could be found. What is the difference? Should the assert be in store.modelFor?

Serabe added a commit to Serabe/data that referenced this issue Jul 13, 2015
@Serabe
Add error message in _pushInternalMessage when unknown type
5eda123 
When pushing data with an unknown type, an error is raised.
Fix emberjs#3542
@Serabe Serabe mentioned this issue Jul 13, 2015
Merged
Serabe added a commit to Serabe/data that referenced this issue Jul 14, 2015
@Serabe
Add error message in _pushInternalMessage when unknown type
e5144c0 
When pushing data with an unknown type, an error is raised.
Fix emberjs#3542
Serabe added a commit to Serabe/data that referenced this issue Jul 14, 2015
@Serabe
[BUGFIX release] Add error message in _pushInternalMessage when unkno…
c35bb68 
…wn type

When pushing data with an unknown type, an error is raised.
Fix emberjs#3542
bmac pushed a commit that referenced this issue Jul 17, 2015
@Serabe @bmac
[BUGFIX release] Add error message in _pushInternalMessage when unkno…
f10822b 
…wn type

When pushing data with an unknown type, an error is raised.
Fix #3542

(cherry picked from commit c35bb68)

Conflicts:
	packages/ember-data/lib/system/store.js
jcope2013 pushed a commit to jcope2013/data that referenced this issue Aug 3, 2015
@Serabe @jcope2013
[BUGFIX release] Add error message in _pushInternalMessage when unkno…
5702082 
…wn type

When pushing data with an unknown type, an error is raised.
Fix emberjs#3542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Serabe @wecc