Add error message in _pushInternalMessage when unknown type #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| store.push({ | ||
| id: '1', | ||
| type: 'unknown' | ||
| }); |
There was a problem hiding this comment.
This should be valid JSON API and has to be wrapped in data:
{
data: {
type: 'unknown',
id: '1'
}
}
|
Thank you, @wecc. Solved. |
|
LGTM, @bmac? |
|
Looks good. @Serabe Could you amend the commit message to start with [BUGFIX release] so we can include this in a future 1.13 release? |
…wn type When pushing data with an unknown type, an error is raised. Fix emberjs#3542
|
Done! |
bmac
added a commit
that referenced
this pull request
Jul 14, 2015
Add error message in _pushInternalMessage when unknown type
|
Thanks @Serabe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pushing data with an unknown type, an error is raised.
Fix #3542