Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-data 2.13+ throws error when booting ember-engines #4968

Closed
rwjblue opened this issue May 4, 2017 · 3 comments
Closed

ember-data 2.13+ throws error when booting ember-engines #4968

rwjblue opened this issue May 4, 2017 · 3 comments

Comments

@rwjblue
Copy link
Member

rwjblue commented May 4, 2017

The deprecations added as part of #4657 are written in a way that assumes the argument passed into the instance-initializer has an application property. This is true for normal applications, but is not true for engines (which still run our instance-initializers).

Specifically [this line] errors (because application.application is null):

  deprecateOldEmberDataInitializers(application.application.constructor.initializers);
@rwjblue
Copy link
Member Author

rwjblue commented May 4, 2017

I'm looking at fixing now...

@rwjblue
Copy link
Member Author

rwjblue commented May 4, 2017

Submitted PR's to fix ( #4969 and #4970).

@sly7-7
Copy link
Contributor

sly7-7 commented May 4, 2017

Likely fixed 😄 Thanks @rwjblue

@sly7-7 sly7-7 closed this as completed May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants